Decouple VariantAnalysisManager from VariantAnalysisResultsManager#1657
Merged
elenatanasoiu merged 2 commits intomainfrom Oct 26, 2022
Merged
Decouple VariantAnalysisManager from VariantAnalysisResultsManager#1657elenatanasoiu merged 2 commits intomainfrom
elenatanasoiu merged 2 commits intomainfrom
Conversation
elenatanasoiu
changed the title
At the moment we create the results manager as a private property on the `VariantAnalysisManager`. If we instead created it at the extension level and passed it to the `VariantAnalysisManager`, we would have more freedom to write unit tests for the `VariantAnalysisManager` without needing to reach into a private results manager property.
elenatanasoiu
force-pushed
the
elena/decouple-manager-from-results
branch
from
9bb6c5f to
d49bffe
Compare
Contributor
Author
|
Helps us write some tests around removal of query history items without having to make the |
koesie10
approved these changes
Oct 26, 2022
| this.variantAnalysisMonitor.onVariantAnalysisChange(this.onVariantAnalysisUpdated.bind(this)); | ||
|
|
||
| this.variantAnalysisResultsManager = this.push(new VariantAnalysisResultsManager(cliServer, logger)); | ||
| this.variantAnalysisResultsManager = this.push(variantAnalysisResultsManager); |
Member
There was a problem hiding this comment.
I don't think we need to push this since the object is not managed by the variant analysis manager; we are already adding it as a disposable to ctx.subscriptions in the extension.ts file.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment we create the results manager as a private property on the
VariantAnalysisManager.If we instead created it at the extension level and passed it to the
VariantAnalysisManager, we would have more freedom to write unit tests for theVariantAnalysisManagerwithout needing to reach into a private results manager property.Checklist
ready-for-doc-reviewlabel there.